Fix case-sensitive tool ID comparison in pruning logic #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, tool call IDs were compared using case-sensitive includes() checks, which could cause re-processing of already pruned tools if the same ID appeared with different casing from different providers. This change normalizes IDs to lowercase before comparison using a Set for efficient O(1) lookups instead of O(n) array includes() calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
The pruning logic in
janitor.tswas using case-sensitiveincludes()checks to determine if a tool call ID had already been pruned. This could fail if the same tool call ID was received with different casing (e.g., from different API providers), causing unnecessary re-processing.This fix normalizes all IDs to lowercase before comparison and uses a
Setfor efficient lookups.